Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add native stake program #62

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

2501babe
Copy link
Member

@2501babe 2501babe commented Dec 6, 2024

this makes it easy to write tests that use test_case to run against both native and bpf stake to confirm the results are the same

i wasnt entirely use on naming stake_program vs solana_stake_program, i think the latter is what we prefer now, and we might want to rename system_program to solana_system_program

Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind putting this behind a feature flag? How about we just use all-builtins, and I can stick other builtins in here too later, like vote.

@buffalojoec buffalojoec added v2.0 Backport to solana-v2.0 v1.18 Backport to solana-v1.18 labels Dec 10, 2024
@2501babe
Copy link
Member Author

i didnt add system_program to the feature since the bpf test program depends on it, i think this is fine until we are working on a bpf system program

@2501babe 2501babe requested a review from buffalojoec December 10, 2024 08:48
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works for me, thanks!

@buffalojoec buffalojoec merged commit 11d1530 into anza-xyz:main Dec 10, 2024
4 checks passed
buffalojoec pushed a commit that referenced this pull request Dec 10, 2024
buffalojoec pushed a commit that referenced this pull request Dec 10, 2024
@2501babe 2501babe deleted the native-stake branch December 11, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.18 Backport to solana-v1.18 v2.0 Backport to solana-v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants